Add extra fields to group wrapper #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Jul 31, 2024
Comment on lines
+23
to
+24
| "description" to group.description, | ||
| "pinnedFrameUrl" to group.pinnedFrameUrl |
There was a problem hiding this comment.
Probably no cost in adding these as well here. But I don't really see a scenario where you would need them in a group list context?
nmalzieu
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
This is to avoid calling the RN bridge later right?
Always a nice to have, however as discussed with Alex I think that if we managed to kill libxmtp with deadlocks, even if Converse absolutely needs to be optimized, given the # of groups we have, it means there is a bug in libxmtp we need to fix.
LGTM
|
🎉 This PR is included in version 2.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few extra fields to the group wrapper so listing groups can have access to name and urls more efficiently.
Also exposes dbPath and a static inbox id method on client.
Closes: #453
Closes: #451